Tools: Topology: Add 7 channel to up/downmix in nocodec#10107
Closed
ujfalusi wants to merge 1 commit intothesofproject:mainfrom
Closed
Tools: Topology: Add 7 channel to up/downmix in nocodec#10107ujfalusi wants to merge 1 commit intothesofproject:mainfrom
ujfalusi wants to merge 1 commit intothesofproject:mainfrom
Conversation
The channel count 7 was somehow missed by the initial commit, which I don't think was on purpose. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
commented
Jul 9, 2025
| in_valid_bit_depth 16 | ||
| in_channels 7 | ||
| in_ch_cfg $CHANNEL_CONFIG_5_POINT_1 | ||
| in_ch_map $CHANNEL_MAP_5_POINT_1 |
Contributor
Author
There was a problem hiding this comment.
these ch config should be fixed, it is not correct.
Contributor
Author
|
There is no valid channel map for 7 channels and we can only say that channels_min/max for supported channel count. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The channel count 7 was somehow missed by the initial commit, which I don't think was on purpose.